Skip to content

Conversation

@ljia5
Copy link
Contributor

@ljia5 ljia5 commented Feb 5, 2025

No description provided.

@sysopenci
Copy link

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

@sysopenci
Copy link

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

1 similar comment
@sysopenci
Copy link

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

@sysopenci
Copy link

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

@sysopenci
Copy link

Program name for this pr is not compatable with other dependent prs, for more details please check tracked_on

ljia5 added 3 commits March 10, 2025 14:09
1. Enable daemon for hdcp1.4/hdcp2.2
2. Add hdcp Test Utility

Tracked-On: OAM-130842
Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>
Change to Android.bp for hdcp build

Tracked-On: OAM-130842
Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>
Open virtio_gpu drm device for acrn support

Tracked-On: OAM-130842
Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>
1. Remove hdcpd srm function due to avoid hdcpd build fail
2. Delete unused build code

Tracked-On: OAM-130842
Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>

LOCAL_CPPFLAGS := \
-DANDROID \
-DUSES_IA_HWCOMPOSER \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why still need use USES_IA_HWCOMPOSER?

{
HDCP_ASSERTMESSAGE("Attempting HDCP Enable");
HDCP_ASSERTMESSAGE("Attempting HDCP Enable, value =%d", value);
HDCP_ASSERTMESSAGE("Attempting HDCP Enable, propValue =%d", propValue);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can combine together as one message

//This is only for HDCP2.2
HDCP_ASSERTMESSAGE("Attempting HDCP Enable Type 1");
HDCP_ASSERTMESSAGE("Attempting HDCP Enable Type, value =%d", value);
HDCP_ASSERTMESSAGE("Attempting HDCP Enable Type, propValue =%d", propValue);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can combine together as one message

# OTHER DEALINGS IN THE SOFTWARE.


add_subdirectory(hdcpTestUtility)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need this?


target_compile_options(${PROJECT_NAME} PRIVATE ${HDCP_CXX_FLAGS})

target_link_libraries(${PROJECT_NAME} hdcpsdk)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it it necessary?

{
if (nullptr == ctx)
{
printf("hdcp context pointer is null\n");
Copy link

@feijiang1 feijiang1 Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If need support both linux and Andorid, we need wrap it, call printf for linux, call LOGD for Android

1. Remove unsed source code
2. Rename USES_IA_HWCOMPOSER define

Tracked-On: OAM-130842
Signed-off-by: Jia, Lin A <lin.a.jia@intel.com>
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Failed labels Mar 20, 2025
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit ccd30e4 into projectceladon:master Mar 23, 2025
14 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon-merge/1087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants