Skip to content

Add virtio ioctl parameters needed for ivshmem detection . #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sysopenci merged 1 commit into from
Jan 17, 2025
Merged

Add virtio ioctl parameters needed for ivshmem detection . #37

sysopenci merged 1 commit into from
Jan 17, 2025

Conversation

@manxiaoliang
Copy link

@manxiaoliang manxiaoliang commented Jan 16, 2025

Addtionally need read VIRTGPU_PARAM_RESOURCE_BLOB.

Add DRM_VIRTGPU_RESOURCE_CREATE_BLOB &
DRM_VIRTGPU_PARAM_QUERY_DEV

Tracked-On: OAM-129380

@sysopenci sysopenci added Valid commit message Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Jan 16, 2025
@manxiaoliang
Add virtio ioctl parameters needed for ivshmem detection
9104591 
Added ioctls DRM_VIRTGPU_RESOURCE_CREATE_BLOB &
DRM_VIRTGPU_PARAM_QUERY_DEV used by hwcomposer to detect ivshmem usage.

Tracked-On: OAM-129380
Signed-off-by: manxiaoliang <xiaoliangx.man@intel.com>
feijiang1
feijiang1 approved these changes Jan 16, 2025
View reviewed changes
Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeevakaPrabu
JeevakaPrabu requested changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@JeevakaPrabu JeevakaPrabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommended commit message:

Add virtio ioctl parameters needed for ivshmem detection

Added ioctls DRM_VIRTGPU_RESOURCE_CREATE_BLOB &
DRM_VIRTGPU_PARAM_QUERY_DEV used by hwcomposer to detect ivshmem usage.

Tracked-On: OAM-129380
Signed-off-by: manxiaoliang xiaoliangx.man@intel.com

@sysopenci sysopenci requested a review from feijiang1 January 16, 2025 06:46
feijiang1
feijiang1 approved these changes Jan 16, 2025
View reviewed changes
Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manxiaoliang manxiaoliang changed the title IsIvshmDev can return true only when QNX/screencast display Add virtio ioctl parameters needed for ivshmem detection . Jan 16, 2025
@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Jan 16, 2025
@sysopenci
Copy link

sysopenci commented Jan 16, 2025

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@iViggyPrabhu iViggyPrabhu reopened this Jan 16, 2025
@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started and removed Pending PR Review Pending PR Review labels Jan 16, 2025
@sysopenci sysopenci requested a review from feijiang1 January 16, 2025 09:06
@sysopenci
Copy link

sysopenci commented Jan 16, 2025

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

1 similar comment
@sysopenci
Copy link

sysopenci commented Jan 16, 2025

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

feijiang1
feijiang1 approved these changes Jan 16, 2025
View reviewed changes
Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

sysopenci commented Jan 17, 2025

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

1 similar comment
@sysopenci
Copy link

sysopenci commented Jan 17, 2025

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

sysopenci commented Jan 17, 2025

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful Developer Approved and removed Engineering Build Not Started Engineering Build Not Started Pending Developer Approval Pending Developer Approval labels Jan 17, 2025
@sysopenci sysopenci added PR approved and removed Pending PR Review Pending PR Review labels Jan 17, 2025
@sysopenci
Copy link

sysopenci commented Jan 17, 2025

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit bda27c3 into projectceladon:v2.4.115 Jan 17, 2025
33 checks passed
@sysopenci
Copy link

sysopenci commented Jan 17, 2025

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon-merge/941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeevakaPrabu JeevakaPrabu JeevakaPrabu approved these changes

+2 more reviewers

@renchenglei renchenglei renchenglei approved these changes

@feijiang1 feijiang1 feijiang1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Developer Approved Engineering Build Successful Engineering Build Successful PR approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@manxiaoliang @sysopenci @renchenglei @JeevakaPrabu @feijiang1 @iViggyPrabhu