Skip to content

[v4.1.x] Fix installed pkgconfig files using wrong linker argument #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kblaschke merged 1 commit into from
Dec 7, 2025
+4 −4
Merged

[v4.1.x] Fix installed pkgconfig files using wrong linker argument #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/GeneratePkgConfigFiles.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ macro(GENERATE_PKG_CONFIG_FILES target package_name)
endforeach()
endif()

# Get name for "-l:<name>" linker flags
# Get name for "-l<name>" linker flags
get_target_property(_lib_name ${target} OUTPUT_NAME)

# Using different package name for debug and release, as pkg-config doesn't support
Expand Down
2 changes: 1 addition & 1 deletion cmake/pkgconfig-file.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ Name: @PKGCONFIG_PACKAGE_NAME@
Version: @PROJECT_VERSION@
Description: @PKGCONFIG_PACKAGE_DESCRIPTION@
Requires: @PKGCONFIG_PACKAGE_REQUIREMENTS@
Libs: -L${libdir} -l:@PKGCONFIG_PROJECTM_LIBRARY@ @PKGCONFIG_LIBS@
Libs: -L${libdir} -l@PKGCONFIG_PROJECTM_LIBRARY@ @PKGCONFIG_LIBS@
Cflags: -I${includedir} @PKGCONFIG_FLAGS@
2 changes: 1 addition & 1 deletion src/libprojectM/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ if(ENABLE_INSTALL)
# into pkgconfig's expected format.
# We will just assume the build uses Boost from the default location (e.g. not a custom CMAKE_PREFIX_PATH) and
# the library name is correct.
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -l:boost_filesystem")
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -lboost_filesystem")
endif()

set(PKGCONFIG_PACKAGE_NAME "${PROJECTM_LIBRARY_BASE_OUTPUT_NAME}")
Expand Down
2 changes: 1 addition & 1 deletion src/playlist/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ if(ENABLE_INSTALL)
# into pkgconfig's expected format.
# We will just assume the build uses Boost from the default location (e.g. not a custom CMAKE_PREFIX_PATH) and
# the library name is correct.
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -l:boost_filesystem")
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -lboost_filesystem")
endif()

set(PKGCONFIG_PACKAGE_NAME "${PROJECTM_LIBRARY_BASE_OUTPUT_NAME}-playlist")
Expand Down
Loading