tmp #925
Draft
tmp #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
force-pushed
the
invidian/missing-constraints
branch
from
2327fca to
f3144b3
Compare
This causes CI time to blow up because in CI we split builds so that each distro is built in a separate job, however with the test the way it was before we ended up having to do additional work to build 2 other distros which takes up a bunch of extra time (fetch the images, prepare worker image) and space. The change, instead of building each target, now just builds the primary and asserts that none of the other distro's artifacts are in it. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
invidian
force-pushed
the
invidian/missing-constraints
branch
from
f3144b3 to
7731148
Compare
invidian
force-pushed
the
invidian/missing-constraints
branch
from
7731148 to
ed08895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: