chore: changed validatable check to be more obvious

Author: andrepimpao

src/Rule/All.php

@@ -5,12 +5,12 @@
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\AllException;
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\UnexpectedValueException;
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\ValidationException;
-use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\AssertIsValidatableTrait;
+use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\IsValidatableTrait;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class All extends AbstractRule implements RuleInterface
 {
-    use AssertIsValidatableTrait;
+    use IsValidatableTrait;
 
     private array $options;
 
@@ -33,7 +33,11 @@ public function __construct(
 
     public function assert(mixed $value, string $name): void
     {
-        $this->assertIsValidatable($this->constraints);
+        if (!$this->isValidatable($this->constraints)) {
+            throw new UnexpectedValueException(
+                'All constraints must be of type "RuleInterface".'
+            );
+        }
 
         if (!\is_array($value)) {
             throw new UnexpectedValueException(

…c/Rule/Util/AssertIsValidatableTrait.php src/Rule/Util/IsValidatableTrait.phpsrc/Rule/Util/AssertIsValidatableTrait.php renamed to src/Rule/Util/IsValidatableTrait.php src/Rule/Util/AssertIsValidatableTrait.php renamed to src/Rule/Util/IsValidatableTrait.php

@@ -5,15 +5,13 @@
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\UnexpectedValueException;
 use ProgrammatorDev\YetAnotherPhpValidator\Rule\RuleInterface;
 
-trait AssertIsValidatableTrait
+trait IsValidatableTrait
 {
-    private function assertIsValidatable(array $constraints): bool
+    private function isValidatable(array $constraints): bool
     {
         foreach ($constraints as $constraint) {
             if (!$constraint instanceof RuleInterface) {
-                throw new UnexpectedValueException(
-                    \sprintf('Expected constraint of type "RuleInterface", "%s" given.', get_debug_type($constraint))
-                );
+                return false;
             }
         }
 

tests/AllTest.php

@@ -24,7 +24,7 @@ public static function provideRuleUnexpectedValueData(): \Generator
         yield 'invalid constraint' => [
             new All([new NotBlank(), 'invalid']),
             [1, 2, 3],
-            '/Expected constraint of type "RuleInterface", "(.*)" given./'
+            '/All constraints must be of type "RuleInterface"./'
         ];
         yield 'invalid value type' => [
             new All([new NotBlank()]),