chore: changed comparable check to be more obvious

Author: andrepimpao

src/Exception/UnexpectedComparableException.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace ProgrammatorDev\YetAnotherPhpValidator\Exception;
+
+class UnexpectedComparableException extends UnexpectedValueException
+{
+    public function __construct(string $value1, string $value2)
+    {
+        $message = \sprintf('Cannot compare a type "%s" with a type "%s".', $value1, $value2);
+
+        parent::__construct($message);
+    }
+}

src/Rule/GreaterThan.php

@@ -3,12 +3,13 @@
 namespace ProgrammatorDev\YetAnotherPhpValidator\Rule;
 
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\GreaterThanException;
-use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\AssertIsComparableTrait;
+use ProgrammatorDev\YetAnotherPhpValidator\Exception\UnexpectedComparableException;
+use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\IsComparableTrait;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class GreaterThan extends AbstractRule implements RuleInterface
 {
-    use AssertIsComparableTrait;
+    use IsComparableTrait;
 
     private array $options;
 
@@ -28,7 +29,12 @@ public function __construct(private readonly mixed $constraint, array $options =
      */
     public function assert(mixed $value, string $name): void
     {
-        $this->assertIsComparable($this->constraint, $value);
+        if (!$this->isComparable($this->constraint, $value)) {
+            throw new UnexpectedComparableException(
+                get_debug_type($this->constraint),
+                get_debug_type($value)
+            );
+        }
 
         if (!($value > $this->constraint)) {
             throw new GreaterThanException(

src/Rule/GreaterThanOrEqual.php

@@ -4,12 +4,13 @@
 
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\GreaterThanException;
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\GreaterThanOrEqualException;
-use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\AssertIsComparableTrait;
+use ProgrammatorDev\YetAnotherPhpValidator\Exception\UnexpectedComparableException;
+use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\IsComparableTrait;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class GreaterThanOrEqual extends AbstractRule implements RuleInterface
 {
-    use AssertIsComparableTrait;
+    use IsComparableTrait;
 
     private array $options;
 
@@ -29,7 +30,12 @@ public function __construct(private readonly mixed $constraint, array $options =
      */
     public function assert(mixed $value, string $name): void
     {
-        $this->assertIsComparable($this->constraint, $value);
+        if (!$this->isComparable($this->constraint, $value)) {
+            throw new UnexpectedComparableException(
+                get_debug_type($this->constraint),
+                get_debug_type($value)
+            );
+        }
 
         if (!($value >= $this->constraint)) {
             throw new GreaterThanOrEqualException(

src/Rule/LessThan.php

@@ -3,12 +3,13 @@
 namespace ProgrammatorDev\YetAnotherPhpValidator\Rule;
 
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\LessThanException;
-use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\AssertIsComparableTrait;
+use ProgrammatorDev\YetAnotherPhpValidator\Exception\UnexpectedComparableException;
+use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\IsComparableTrait;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class LessThan extends AbstractRule implements RuleInterface
 {
-    use AssertIsComparableTrait;
+    use IsComparableTrait;
 
     private array $options;
 
@@ -28,7 +29,12 @@ public function __construct(private readonly mixed $constraint, array $options =
      */
     public function assert(mixed $value, string $name): void
     {
-        $this->assertIsComparable($this->constraint, $value);
+        if (!$this->isComparable($this->constraint, $value)) {
+            throw new UnexpectedComparableException(
+                get_debug_type($this->constraint),
+                get_debug_type($value)
+            );
+        }
 
         if (!($value < $this->constraint)) {
             throw new LessThanException(

src/Rule/LessThanOrEqual.php

@@ -3,12 +3,13 @@
 namespace ProgrammatorDev\YetAnotherPhpValidator\Rule;
 
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\LessThanOrEqualException;
-use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\AssertIsComparableTrait;
+use ProgrammatorDev\YetAnotherPhpValidator\Exception\UnexpectedComparableException;
+use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\IsComparableTrait;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class LessThanOrEqual extends AbstractRule implements RuleInterface
 {
-    use AssertIsComparableTrait;
+    use IsComparableTrait;
 
     private array $options;
 
@@ -28,7 +29,12 @@ public function __construct(private readonly mixed $constraint, array $options =
      */
     public function assert(mixed $value, string $name): void
     {
-        $this->assertIsComparable($this->constraint, $value);
+        if (!$this->isComparable($this->constraint, $value)) {
+            throw new UnexpectedComparableException(
+                get_debug_type($this->constraint),
+                get_debug_type($value)
+            );
+        }
 
         if (!($value <= $this->constraint)) {
             throw new LessThanOrEqualException(

src/Rule/Range.php

@@ -3,14 +3,15 @@
 namespace ProgrammatorDev\YetAnotherPhpValidator\Rule;
 
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\RangeException;
+use ProgrammatorDev\YetAnotherPhpValidator\Exception\UnexpectedComparableException;
 use ProgrammatorDev\YetAnotherPhpValidator\Exception\UnexpectedValueException;
-use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\AssertIsComparableTrait;
+use ProgrammatorDev\YetAnotherPhpValidator\Rule\Util\IsComparableTrait;
 use ProgrammatorDev\YetAnotherPhpValidator\Validator;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class Range extends AbstractRule implements RuleInterface
 {
-    use AssertIsComparableTrait;
+    use IsComparableTrait;
 
     private array $options;
 
@@ -31,7 +32,12 @@ public function __construct(
 
     public function assert(mixed $value, string $name): void
     {
-        $this->assertIsComparable($this->minConstraint, $this->maxConstraint);
+        if (!$this->isComparable($this->minConstraint, $this->maxConstraint)) {
+            throw new UnexpectedComparableException(
+                get_debug_type($this->minConstraint),
+                get_debug_type($this->maxConstraint)
+            );
+        }
 
         if (
             !Validator

src/Rule/Util/AssertIsComparableTrait.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace ProgrammatorDev\YetAnotherPhpValidator\Rule\Util;
+
+trait IsComparableTrait
+{
+    private function isComparable(mixed $value1, mixed $value2): bool
+    {
+        if ($value1 instanceof \DateTimeInterface && $value2 instanceof \DateTimeInterface) {
+            return true;
+        }
+
+        if (\is_numeric($value1) && \is_numeric($value2)) {
+            return true;
+        }
+
+        if (\is_string($value1) && \is_string($value2)) {
+            return true;
+        }
+
+        return false;
+    }
+}