-
-
Notifications
You must be signed in to change notification settings - Fork 645
Fix build on Hurd. #2588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix build on Hurd. #2588
Conversation
|
This should probably be added to the |
|
Hi, I think this is already there? There are some |
|
I am talking specifically about adding it to the |
|
I apologise but I dont quite understand what you mean by that. The option should be already there https://github.com/premake/premake-core/blob/master/src/_premake_init.lua#L1595 This was originally added in cf9fb33 It is missing from the documentation but the list at https://premake.github.io/docs/system seems a bit out of date with the accepted options in that file in general. Am I missing something or is there more to it? |
|
On another note should all the |
Here is where you can register it as a system and the corresponding docs: premake-core/src/_premake_init.lua Line 857 in 5353206
https://github.com/premake/premake-core/blob/master/website/docs/system.md |
Add PLATFORM_HURD to PLATFORM_POSIX.
What does this PR do?
Fixes a build failure when building for Hurd systems.
I tried to crossbuild for a gnu hurd system and found this error in
os_getpass.cHow does this PR change Premake's behavior?
N/A
Are there any breaking changes? Will any existing behavior change?
No
Anything else we should know?
Are there any rules for the order in PLATFORM_POSIX, i put it before PLATFORM_COSMO to join the group of the other OSes as
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!