Skip to content

Conversation

@Dariqq
Copy link

@Dariqq Dariqq commented Jan 3, 2026

What does this PR do?

Fixes a build failure when building for Hurd systems.

I tried to crossbuild for a gnu hurd system and found this error in os_getpass.c

../../src/host/os_getpass.c:42:18: error: #error Not implemented yet for this platform

How does this PR change Premake's behavior?
N/A

Are there any breaking changes? Will any existing behavior change?

No

Anything else we should know?

Are there any rules for the order in PLATFORM_POSIX, i put it before PLATFORM_COSMO to join the group of the other OSes as

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016
Copy link
Member

This should probably be added to the system API as well (and the docs).

@Dariqq
Copy link
Author

Dariqq commented Jan 4, 2026

Hi,

I think this is already there? There are some system:hurd filters in this premake5.lua and hurd is an accepted value for --os. Or are you talking about something different?

@nickclark2016
Copy link
Member

I am talking specifically about adding it to the system API, as well as the corresponding documentation.

@Dariqq
Copy link
Author

Dariqq commented Jan 4, 2026

I apologise but I dont quite understand what you mean by that.

The option should be already there https://github.com/premake/premake-core/blob/master/src/_premake_init.lua#L1595

This was originally added in cf9fb33

It is missing from the documentation but the list at https://premake.github.io/docs/system seems a bit out of date with the accepted options in that file in general.

Am I missing something or is there more to it?

@Dariqq
Copy link
Author

Dariqq commented Jan 5, 2026

On another note should all the | be actually || in os_getnumcpus.c

@nickclark2016
Copy link
Member

I apologise but I dont quite understand what you mean by that.

The option should be already there https://github.com/premake/premake-core/blob/master/src/_premake_init.lua#L1595

This was originally added in cf9fb33

It is missing from the documentation but the list at https://premake.github.io/docs/system seems a bit out of date with the accepted options in that file in general.

Am I missing something or is there more to it?

Here is where you can register it as a system and the corresponding docs:

api.register {

https://github.com/premake/premake-core/blob/master/website/docs/system.md

Dariqq and others added 2 commits January 8, 2026 19:55
Add PLATFORM_HURD to PLATFORM_POSIX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants