types: Correct outdated imports in jsx-runtime
#4981
Merged
+27
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
commented
Dec 27, 2025
| @@ -1,58 +0,0 @@ | |||
| /** | |||
Member
Author
There was a problem hiding this comment.
Was added for Vitest but conflicts with our @types/node version and seems unnecessary now. I imagine this was a holdover until we had bumped @types/node and just forgot to clean it up.
| object: object; | ||
| } | ||
|
|
||
| export type WeakKey = WeakKeyTypes[keyof WeakKeyTypes]; |
JoviDeCroock
approved these changes
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4980
The actual fix was straightforward, only touching
/jsx-runtime/src/index.d.ts, but the linting fix was more involved.Whilst we have a linter that should've caught that problem, turns out we had
skipLibCheck: trueenabled -- this skips checking for source.d.tsfiles as well as those innode_modules. Removing this immediately caused issues however asviteandvitestrequire more modern TS setups.As such, the
jsconfig-lint.jsongot a bit of a facelift to make it more modern & compatible, whilst also removing theskipLibChecksetting so that we now get warned of type errors again. Yay.Re:
compat/server.d.ts, no idea what to do about that one. TS is grumpy about the mixed exports (rightfully so) and I spent an hour trying various ways to get around it with no luck. It works at runtime for consumers, so I just silenced the errors. We know that's a problem with our types anyhow (ESM-only anyone??)