-
Notifications
You must be signed in to change notification settings - Fork 3
Pytestless doctests #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: update_devdocs
Are you sure you want to change the base?
Pytestless doctests #177
Conversation
8e46cb3 to
fd9a1ca
Compare
f4a4ab4 to
d1b7213
Compare
ef86558 to
506dc26
Compare
a7ece14 to
96ef52c
Compare
3f4b3b4 to
6e27328
Compare
for more information, see https://pre-commit.ci
| ) -> list[Path]: | ||
| """Expand globs to a list of filepaths. | ||
|
|
||
| Also filter with exclude controls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "private" concept does not apply to documentation files : Explain this?
| """ | ||
| actual_paths: list[Path] = [] | ||
| segments = file_path.split("/") | ||
| i_wilds = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: document the intention.
In order to resolve a globbed path like dir/subdir/**/*AB_test.extension, we need to split the root path of the search from the wildcarded parts, to do Path("dir/subdir").glob("**/*AB_test.extension")
So here we are finding which path segments contain glob characters, and splitting at the first of those.
This probably is still a bit crude
- e.g. can't handle escaped glob chars
- e.g. maybe doesn't work (needs testing) if the globbed part or unglobbed parts are empty
What is still missing?Apart from the above, this is still only "trial code". What's really driving that is a desire to use this for Iris too. Probably, it would still be good to have a distinct repo, for central control + to host testing, What's I can already see is still missing with the function itself ..
|
Pursuing an idea that we might create a better test-runner than pytest, for ourselves