Skip to content

fix(node): load properly better-sqlite3 #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flochaz wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(node): load properly better-sqlite3 #795

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65af2d4
fix(node): load properly better-sqlite3
flochaz Dec 11, 2025
af44fdb
chore: add changeset for better-sqlite3 fix
flochaz Dec 11, 2025
2510256
Merge branch 'main' into fixBetterSQlite3Init
flochaz Dec 11, 2025
91190df
Update .changeset/fix-better-sqlite3.md
flochaz Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/node/src/db/SqliteWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ export function startPowerSyncWorker(options?: Partial<PowerSyncWorkerOptions>)
},
async loadBetterSqlite3() {
const module = await dynamicImport('better-sqlite3');
return module.default;
return module && typeof module === 'object' && 'default' in module
? module.default
: module;
Comment on lines +87 to +89
Copy link
Contributor

@simolus3 simolus3 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might make it clearer what's going on:

Suggested change
return module && typeof module === 'object' && 'default' in module
? module.default
: module;
// require() gives us the default directly, for an ESM import() we need to use the default export.
return isBundledToCommonJs ? module : module.default;

},
...options
};
Expand Down