-
Notifications
You must be signed in to change notification settings - Fork 1
Add Docs on Targets and Stages (Prod Pipes) #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
MattWellie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added thoughts, but I'm not sure how much of the 'what is a cohort' question should be answered here
|
|
||
| ### Cohort | ||
|
|
||
| A Cohort is a curated group of SequencingGroups that share common characteristics or criteria. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Cohort is a curated group of SequencingGroups
We should be explicit here that the curation of the SGs is a process handled by you (the reader of this guide), not just a process that happens passively. Maybe a link to guidance on when & how to mint a new cohort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like "In PP the term 'Cohort' relates to a single Custom Cohort, created using the XX process link to documentation. Each cohort consists of a collection of SequencingGroups, and a pipeline run can be comprised of multiple overlapping or non-overlapping Cohorts"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This distinction might be out of scope for this doc
michael-harper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @vivbak - super clear, no questions on my end :) thank you!
Post multi-cohorts, this doc acts as a guide on when to use which stage type.