Release/v0.1.1

.eslintrc.js

@@ -7,7 +7,7 @@ module.exports = {
         'plugin:@typescript-eslint/recommended', // Uses the recommended rules from @typescript-eslint/eslint-plugin
         'plugin:react/recommended', // Uses the recommended rules from @eslint-plugin-react
         'prettier/@typescript-eslint', // Uses eslint-config-prettier to disable ESLint rules from @typescript-eslint/eslint-plugin that would conflict with prettier
-        'plugin:prettier/recommended', // Enables eslint-plugin-prettier and displays prettier errors as ESLint errors. Make sure this is always the last configuration in the extends array.
+        'plugin:prettier/recommended' // Enables eslint-plugin-prettier and displays prettier errors as ESLint errors. Make sure this is always the last configuration in the extends array.
     ],
     ignorePatterns: ['.eslintrc.js'],
     env: {
@@ -19,45 +19,63 @@ module.exports = {
         sourceType: 'module', // Allows for the use of imports
         // project: 'tsconfig.json',
         ecmaFeatures: {
-            jsx: true, // Allows for the parsing of JSX
+            jsx: true // Allows for the parsing of JSX
         },
         project: './tsconfig.json'
     },
     parser: '@typescript-eslint/parser', // Specifies the ESLint parser
     settings: {
         react: {
-            version: 'detect', // Tells eslint-plugin-react to automatically detect the version of React to use
-        },
+            version: 'detect' // Tells eslint-plugin-react to automatically detect the version of React to use
+        }
     },
     rules: {
         // 'react/prop-types': 0, // no requiring of prop types
         'react/display-name': 0, // allow anonymous components
-        'strict': [2, 'safe'],
-        'no-debugger': 2,
-        'brace-style': [2, '1tbs', { 'allowSingleLine': true }],
-        'no-trailing-spaces': [2, { 'skipBlankLines': true }],
-        'keyword-spacing': 2,
+        strict: [2, 'safe'],
+        'no-debugger': 'error',
+        'brace-style': ['error', '1tbs', {allowSingleLine: true}],
+        'keyword-spacing': ['error'],
+        'comma-spacing': 'error',
+        'object-curly-spacing': ['error', 'never'],
+        'object-curly-newline': ['error', {multiline: true}],
+        'array-bracket-spacing': ['error', 'never'],
         'spaced-comment': [2, 'always'],
         'vars-on-top': 0, // Disable: all 'var' declarations must be at the top of the function scope
         'no-undef': 0,
         'no-undefined': 0,
-        'comma-dangle': [0, 'never'],
-        'quotes': [2, 'double'],
-        'semi': 1,
+        'comma-dangle': ['error', 'never'],
+        quotes: ['error', 'single', {allowTemplateLiterals: true}],
+        semi: ['error', 'always'],
         'guard-for-in': 0, // allow iterating with for..in without checking for Object.hasOwnProperty
         'no-eval': 2,
         'no-with': 2,
         'valid-typeof': 2,
-        'no-unused-vars': ['error', { 'argsIgnorePattern': '^_' }],
-        '@typescript-eslint/no-unused-vars': ['error', { 'argsIgnorePattern': '^_' }],
+        'no-unused-vars': 'off',
+        '@typescript-eslint/no-unused-vars': [
+            'error',
+            {argsIgnorePattern: '^_', varsIgnorePattern: '^_'}
+        ],
         'no-continue': 1,
-        'no-unreachable': 1,
-        'no-unused-expressions': 1,
+        'no-unreachable': 'error',
+        'no-unused-expressions': 'error',
+        'no-duplicate-imports': 'error',
         'no-magic-numbers': 0,
         'no-inner-declarations': 0,
         'no-constant-condition': 0,
         'no-empty-function': 0,
-        'max-len': [1, 120, 4],
+        'arrow-body-style': ['error', 'as-needed'],
+        'max-len': [
+            'warn',
+            {
+                code: 100,
+                ignoreStrings: true,
+                ignoreRegExpLiterals: true,
+                ignoreTemplateLiterals: true,
+                tabWidth: 4,
+                ignoreComments: true
+            }
+        ],
         'react/prefer-es6-class': 1,
         '@typescript-eslint/explicit-function-return-type': 0,
         '@typescript-eslint/no-use-before-define': 0,
@@ -68,5 +86,31 @@ module.exports = {
         '@typescript-eslint/no-extra-semi': 0,
         '@typescript-eslint/no-empty-function': ['off'],
         '@typescript-eslint/ban-ts-comment': 0,
-    },
+        semi: ['error', 'always'],
+        'linebreak-style': ['error', 'unix'],
+        curly: ['error', 'multi-line'],
+        indent: [
+            'error',
+            4,
+            {
+                SwitchCase: 1,
+                MemberExpression: 1,
+                ArrayExpression: 1,
+                ObjectExpression: 1,
+                VariableDeclarator: 1,
+                CallExpression: {arguments: 1},
+                offsetTernaryExpressions: true
+            }
+        ],
+        'space-in-parens': ['error', 'never'],
+        'no-case-declarations': 'warn',
+        eqeqeq: ['error', 'always', {null: 'ignore'}],
+        'prefer-const': ['error', {destructuring: 'all', ignoreReadBeforeAssign: false}],
+        'no-multiple-empty-lines': ['warn', {max: 1, maxEOF: 0}],
+        '@typescript-eslint/no-unsafe-call': 'warn', // TODO: fix and delete rule
+        '@typescript-eslint/no-unsafe-assignment': 'warn', // TODO: fix and delete rule
+        '@typescript-eslint/no-unsafe-member-access': 'warn', // TODO: fix and delete rule
+        '@typescript-eslint/restrict-template-expressions': 'warn', // TODO: fix and delete rule
+        '@typescript-eslint/no-unsafe-return': 'warn' // TODO: fix and delete rule
+    }
 };

.github/workflows/lint.yaml

@@ -0,0 +1,20 @@
+# This workflow will run a lint check
+name: Run ESLint
+
+on:
+  pull_request:
+    branches: [ develop ]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - uses: actions/setup-node@v3
+      with:
+        node-version: 16
+        cache: 'npm'
+    - name: Install dependencies
+      run: npm ci
+    - name: Run ESLint
+      run: npm run lint

.gitignore

@@ -6,4 +6,4 @@ npm-debug.log
 /.parcel-cache
 .DS_Store
 web-ext-artifacts
-
+/.idea

.nvmrc

@@ -1 +1 @@
-v14.8.0
+v16

.prettierignore

@@ -1,2 +1,2 @@
 node_modules/*
-*.snap
+*.snap

.prettierrc.js

@@ -1,6 +1,10 @@
 module.exports = {
     semi: true,
-    trailingComma: "all",
-    singleQuote: false,
+    trailingComma: "none",
+    singleQuote: true,
+    printWidth: 100,
     tabWidth: 4,
+    useTabs: false,
+    bracketSpacing: false,
+    arrowParens: "avoid",
 };

package.json

@@ -1,6 +1,6 @@
 {
     "name": "pointnetwork-browser-extension",
-    "version": "0.0.41",
+    "version": "0.1.1",
     "description": "Point Browser Extension",
     "alias": {
         "pointsdk": "./src"
@@ -83,6 +83,7 @@
     "scripts": {
         "start": "npm run cleanup && parcel src/manifest.json --host localhost --target dev",
         "build": "npm run cleanup && parcel build src/manifest.json --target prod --no-source-maps",
+        "watch": "npm run cleanup && parcel watch src/manifest.json --target prod",
         "build:sdk": "npx parcel@2.4.1 build src/pointsdk/browser.ts --target sdk",
         "cleanup": "rm -rf dist .cache .parcel-cache",
         "test": "jest --config=jest.config.js",

src/background/confirmationWindowApi.ts

@@ -1,4 +1,4 @@
-import browser from "webextension-polyfill";
+import browser from 'webextension-polyfill';
 
 let windowId: number | null = null;
 export const displayConfirmationWindow = async (
@@ -7,21 +7,21 @@ export const displayConfirmationWindow = async (
     host: string,
     network: string,
     params = {},
-    decodedTxData = {},
+    decodedTxData = {}
 ) => {
     const query = new URLSearchParams();
-    query.append("reqId", reqId);
-    query.append("pointId", pointId);
-    query.append("host", host);
-    query.append("network", network);
-    query.append("params", JSON.stringify(params));
-    query.append("decodedTxData", JSON.stringify(decodedTxData));
+    query.append('reqId', reqId);
+    query.append('pointId', pointId);
+    query.append('host', host);
+    query.append('network', network);
+    query.append('params', JSON.stringify(params));
+    query.append('decodedTxData', JSON.stringify(decodedTxData));
 
     const win = await browser.windows.create({
-        type: "detached_panel",
-        width: 400,
+        type: 'detached_panel',
+        width: 512,
         height: 600,
-        url: `./confirmation-window/index.html?${query.toString()}`,
+        url: `./confirmation-window/index.html?${query.toString()}`
     });
     windowId = win.id!;
 };

src/background/index.ts

@@ -1,88 +1,67 @@
-import browser from "webextension-polyfill";
+import browser from 'webextension-polyfill';
 import {
     rpcListener,
     confirmationWindowListener,
     registerHandlerListener,
     setAuthTokenHandler,
-    getAuthToken,
-} from "pointsdk/background/messaging";
+    getAuthToken
+} from 'pointsdk/background/messaging';
 
 const setChainIds = async () => {
     try {
         const token = (await getAuthToken()).token;
-        const networksRes = await fetch(
-            "https://point/v1/api/blockchain/networks",
-            {
-                headers: {
-                    "X-Point-Token": `Bearer ${token}`,
-                },
-            },
-        );
-        const oldDefaultNetwork = await browser.storage.local.get(
-            "default_network",
-        );
-        const { networks, default_network } = await networksRes.json();
+        const opts = {headers: {'X-Point-Token': `Bearer ${token}`}};
+        const networksRes = await fetch('https://point/v1/api/blockchain/networks', opts);
+        const oldDefaultNetwork = await browser.storage.local.get('default_network');
+        const {networks, default_network} = await networksRes.json();
         // TODO: if the default network changed we need to update it everywhere
         // therefore we need to clear the prevoius setting, but this is not polite
         // need to think of a better solution...
         if (oldDefaultNetwork && oldDefaultNetwork !== default_network) {
-            await browser.storage.local.remove("chainIdGlobal"); // it will be set up below
+            await browser.storage.local.remove('chainIdGlobal'); // it will be set up below
             const storage = await browser.storage.local.get(null);
             for (const key in storage) {
-                if (key.startsWith("chainId")) {
-                    await browser.storage.local.set({
-                        [key]: default_network as string,
-                    });
+                if (key.startsWith('chainId')) {
+                    await browser.storage.local.set({[key]: default_network as string});
                 }
             }
         }
         await browser.storage.local.set({
             networks: JSON.stringify(networks),
-            default_network,
+            default_network
         });
-        const { chainIdGlobal } = await browser.storage.local.get(
-            "chainIdGlobal",
-        );
+        const {chainIdGlobal} = await browser.storage.local.get('chainIdGlobal');
         if (!chainIdGlobal || !(chainIdGlobal in networks)) {
-            await browser.storage.local.set({
-                chainIdGlobal: default_network,
-            });
+            await browser.storage.local.set({chainIdGlobal: default_network});
         }
     } catch (e) {
-        console.error("Failed to fetch networks info from the node: ", e);
+        console.error('Failed to fetch networks info from the node: ', e);
         setTimeout(() => {
             void setChainIds();
         }, 1000);
     }
 };
 
-setChainIds();
+void setChainIds();
 
 browser.runtime.onMessage.addListener(async (message, sender) => {
     switch (message.__message_type) {
-        case "rpc":
+        case 'rpc':
             return rpcListener(message);
-        case "registerHandler":
+        case 'registerHandler':
             return registerHandlerListener(message);
-        case "setAuthToken":
+        case 'setAuthToken':
             if (!sender.url?.match(/^https:\/\/point/)) {
-                console.error(
-                    "Attempt to set auth token from unauthorized host",
-                );
+                console.error('Attempt to set auth token from unauthorized host');
                 break;
             }
             return setAuthTokenHandler(message);
-        case "getAuthToken":
+        case 'getAuthToken':
             return getAuthToken();
         default:
-            if (sender.url?.match("confirmation-window")) {
+            if (sender.url?.match('confirmation-window')) {
                 return confirmationWindowListener(message);
             }
-            console.error(
-                "Unexpected runtime message: ",
-                message,
-                " from sender: ",
-                sender,
-            );
+            console.error('Unexpected runtime message: ', message, ' from sender: ', sender);
     }
 });