bls signature #216
bls signature #216
Conversation
|
Nice work so far. Ping me or @lonerapier when a review is needed. |
|
@Autoparallel i think it is ready for review |
|
Alright let me check this out |
Autoparallel
left a comment
Autoparallel
left a comment
There was a problem hiding this comment.
Left some comments. Over all looking good. Can you add more documentation to the modules you created?
Also, can you add a README.md that explains this in detail?
|
@Autoparallel it's been over a month ,can i get a review ? |
|
@mahmudsudo yes, sorry. I was out. Let me also ping my teammates. |
|
@mahmudsudo I just realized we have the Think you can do that in this PR as well? |
Autoparallel
left a comment
Autoparallel
left a comment
There was a problem hiding this comment.
Looking a lot better now. We're close. I left a bit more feedback
Co-authored-by: Colin Roberts <colin@autoparallel.xyz>
Co-authored-by: Colin Roberts <colin@autoparallel.xyz>
Co-authored-by: Colin Roberts <colin@autoparallel.xyz>
1 similar comment
|
If you could, can you clean up the signatures module now? I think it could be better organized into what the actual algorithms are (i.e., |
Autoparallel
left a comment
Autoparallel
left a comment
There was a problem hiding this comment.
Great work!
I talked to @brunny-eth and he will contact you shortly about the bounty.
|
hey @mahmudsudo -- DM-ing you on Telegram per our last discussion |
3 participants
This PR closes issue #195