fix(model): fix dropdown type for is_private field #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonebuzz
approved these changes
Jan 6, 2026
Rom1-B
reviewed
Jan 6, 2026
| {{ fields.textField('name', values['name'], __('Name'), field_options) }} | ||
|
|
||
| {{ fields.dropdownYesNo('is_private', values['is_private'], __('Visibility'), field_options) }} | ||
| {{ fields.dropdownArrayField('is_private', values['is_private'], { |
Contributor
There was a problem hiding this comment.
I would just have changed the label to “Is Private,” for example, to keep the dropdownYesNo() type.
Rom1-B
reviewed
Jan 7, 2026
Rom1-B
approved these changes
Jan 7, 2026
stonebuzz
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change results in a loss of clarity compared to the GLPI 10-compatible version, where this field was represented by a dropdownArrayField with the options Public/Private.
The Yes/No choice does not clearly reflect the concept of model visibility.
Screenshots (if appropriate):
GLPI 10:
GLPI 11 before fix:
GLPI 11 after fix:
