-
Notifications
You must be signed in to change notification settings - Fork 0
[XELP] GHA shadow release #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new GitHub Actions workflow for creating "shadow releases" of the XELP branch. The workflow automatically calculates a modified version number (adding 100 to the major version), builds the project, and publishes it to a separate xelp/dist branch with an appropriate version tag.
- Creates versioned shadow releases from the
xelp/mainbranch - Automates version calculation with a unique naming scheme (major+100, with date and commit hash metadata)
- Builds and commits the distribution files to a dedicated branch with version tagging
16181fb to
d82e04c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
6be2c3f to
374eba7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/xelp_shadow_release.yml:1
- Array splitting logic can fail silently. When IFS='.' read splits the version string on line 38, if the version has fewer than 3 parts, the PARTS array will have fewer elements. Accessing ${PARTS[1]} or ${PARTS[2]} on lines 44-45 won't fail in bash but will result in empty strings, bypassing the check on line 39. This check should be performed immediately after the split, or use safer array access patterns. Move the validation block (lines 39-42) immediately after line 38, before any variable assignments.
name: Xelp Shadow Release
No description provided.