Skip to content

Development #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plebe1us merged 4 commits into from
Oct 11, 2025
Merged

Development #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92d9835
chore(package.json): upgrade plebbit-react-hooks
plebe1us Oct 10, 2025
4829f23
Merge pull request #772 from plebbit/master
plebe1us Oct 11, 2025
d66fc83
fix(challenge): update challenge iframe type
plebe1us Oct 11, 2025
0bdcb4b
fix(challenge-modal): add allow-same-origin to iframe sandbox
plebe1us Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@capacitor/status-bar": "7.0.1",
"@capawesome/capacitor-android-edge-to-edge-support": "7.2.2",
"@floating-ui/react": "0.26.1",
"@plebbit/plebbit-react-hooks": "https://github.com/plebbit/plebbit-react-hooks.git#327920bb0d933388a3eb067a89af66d5d21baaae",
"@plebbit/plebbit-react-hooks": "https://github.com/plebbit/plebbit-react-hooks.git#eecac4503b7099b2dde22505869f2a70d280e14f",
"@testing-library/jest-dom": "5.14.1",
"@testing-library/react": "13.0.0",
"@testing-library/user-event": "13.2.1",
Expand Down
4 changes: 2 additions & 2 deletions src/components/challenge-modal/challenge-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const RegularChallengeContent = ({ challenge, closeModal }: RegularChallengeCont
const currentChallenge = challenges?.[currentChallengeIndex];
const isTextChallenge = currentChallenge?.type === 'text/plain';
const isImageChallenge = currentChallenge?.type === 'image/png';
const isIframeChallenge = currentChallenge?.type === 'text/url-iframe';
const isIframeChallenge = currentChallenge?.type === 'url/iframe';

const isValidAnswer = (index: number) => {
return !!answers[index] && answers[index].trim() !== '';
Expand Down Expand Up @@ -221,7 +221,7 @@ const RegularChallengeContent = ({ challenge, closeModal }: RegularChallengeCont
<iframe
ref={iframeRef}
src={iframeUrlState}
sandbox='allow-scripts allow-forms allow-popups allow-top-navigation-by-user-activation'
sandbox='allow-scripts allow-forms allow-popups allow-same-origin allow-top-navigation-by-user-activation'
onLoad={handleIframeLoad}
className={styles.iframe}
title={t('challenge_iframe', { defaultValue: 'Challenge authentication' })}
Expand Down
16 changes: 16 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3912,6 +3912,22 @@
uuid "11.1.0"
zustand "4.0.0"

"@plebbit/plebbit-react-hooks@https://github.com/plebbit/plebbit-react-hooks.git#eecac4503b7099b2dde22505869f2a70d280e14f":
version "0.0.1"
resolved "https://github.com/plebbit/plebbit-react-hooks.git#eecac4503b7099b2dde22505869f2a70d280e14f"
dependencies:
"@plebbit/plebbit-js" "https://github.com/plebbit/plebbit-js.git#8958f72cc1e4487cabe7d6458df5e77a47571692"
"@plebbit/plebbit-logger" "https://github.com/plebbit/plebbit-logger.git"
assert "2.0.0"
ethers "5.6.9"
localforage "1.10.0"
lodash.isequal "4.5.0"
memoizee "0.4.15"
quick-lru "5.1.1"
uint8arrays "3.1.1"
uuid "11.1.0"
zustand "4.0.0"

"@plebbit/proper-lockfile@github:plebbit/node-proper-lockfile#7fd6332117340c1d3d98dd0afee2d31cc06f72b8":
version "4.1.2"
resolved "https://codeload.github.com/plebbit/node-proper-lockfile/tar.gz/7fd6332117340c1d3d98dd0afee2d31cc06f72b8"
Expand Down