Update StringHelper to avoid converting int's encoding to utf8 #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also have encountered the same problem, especially with server group IDs getting converted into Japanese Kanji. We have a fork that implements the same fix and works. It might also be worth skipping the StringHelper entirely when the value is an integer or a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi together,
I recently hit an problem with the latest version (1.3.0) & with dev branch.
If I select an server by id and the serverId is 11+ it results in an convert error,
After some research I found out that using mb_convert_encoding on 11-19 result in some weird characters like ㄱ as 11 or ㄹ as 19 🤣
I assume that will fix #212.