QueryToResults error handling #137
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Englander <max@planetscale.com>
This was referenced Apr 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling by propagating errors from query-to-result conversion instead of panicking, ensuring that errors are properly surfaced in both tests and runtime.
- Update QueryResultToRecords, parseValue, leadDecimalWithZero, and formatISO8601 to return errors.
- Add error assertions in tests and update sync handling in the Planetscale Edge Database integration.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/internal/types_test.go | Tests now assert no errors when calling QueryResultToRecords. |
| cmd/internal/types.go | Refactors functions to return errors instead of panicking on failure. |
| cmd/internal/planetscale_edge_database.go | Handles errors from QueryResultToRecords in the sync process. |
nickvanw
approved these changes
Apr 3, 2025
Comment on lines
-210
to
+219
| panic(fmt.Sprintf("unexpected query.Type: %#v", queryColumnType)) | ||
| return Value{}, fmt.Errorf("unexpected query.Type: %#v", queryColumnType) |
Collaborator
Author
There was a problem hiding this comment.
i put the panic there originally jfyi 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prev: #136
Surface errors from converting queries to results.
Next: #138