Skip to content

Update Configuration.php for deprecation fix SF5.0 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remigarcia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Configuration.php for deprecation fix SF5.0 #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ public function getConfigTreeBuilder()
{
$supportedDrivers = array('orm', 'mongodb');

$treeBuilder = new TreeBuilder();
$rootNode = $treeBuilder->root('pix_sortable_behavior');
$treeBuilder = new TreeBuilder('pix_sortable_behavior');
$rootNode = $treeBuilder->getRootNode();
Copy link

@tifabien tifabien Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a BC layer for this deprecation notice

Suggested change
$rootNode = $treeBuilder->getRootNode();
$builder = new TreeBuilder('pix_sortable_behavior');
if (\method_exists($builder, 'getRootNode')) {
$rootNode = $builder->getRootNode();
} else {
// BC layer for symfony/config 4.1 and older
$rootNode = $builder->root('pix_sortable_behavior');
}


$rootNode
->children()
Expand Down