fix: restore external access to Context fields #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit dd9b662 inadvertently made Context fields and subfields inaccessible to library users, breaking the ability to inspect Context contents (e.g., using AsMap()). This change restores public visibility to the relevant Context fields, allowing external code to access all necessary data. Internal fields (e.g., those used for caching) remain private. Additionally, this commit removes the unused 'typ' field from Values by inlining its default value (the empty string), as it was never set. Signed-off-by: Michael Adler <michael.adler@siemens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Commit dd9b662 inadvertently made Context fields and subfields inaccessible to library users, breaking the ability to inspect Context contents (e.g., using AsMap()). This change restores public visibility to the relevant Context fields, allowing external code to access all necessary data. Internal fields (e.g., those used for caching) remain private.
Additionally, this commit removes the unused 'typ' field from Values by inlining its default value (the empty string), as it was never set.
Motivation
Contextcan be useful for downstream, 3rd party librariesChecks
make test