Skip to content
This repository was archived by the owner on Nov 17, 2020. It is now read-only.

Conversation

@plicease
Copy link
Contributor

Regarding #12 This works -ish. 003-load.t fails for me sometimes, I think due to a race condition:

t/003-load.t .......... 1/9 
#   Failed test at t/003-load.t line 20.
#          got: '0.08'
#     expected: '0.07'
# Looks like you failed 1 test of 9.
t/003-load.t .......... Dubious, test returned 1 (wstat 256, 0x100)

On my Debian kFreeBSD box you can also use the Linux driver, as the /proc file system is installed. I am not sure if you can count on /proc being available, however. Curiously using the Linux interface does not seem to suffer this race condition as often.

@pioto
Copy link
Owner

pioto commented Jun 19, 2018

Yes, there's some amount of raciness involved in that test, which I think I have another pull request sitting around to address.

To set expectations, though... I haven't really touched this code much in several years, so I don't really have a dev environment set up anymore to test, or build releases with. I appreciate the contribution, but I probably won't be able to give it too much attention for a few months (Real Life, etc).

I also don't have much direct use of this module anymore, or much involvement with Perl in general...

If you want to "volunteer" to take up maintainership of this on CPAN and such, I probably wouldn't object.

Copy link
Owner

@pioto pioto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this also needs an update to the use Devel::AssertOS line?

For example, see:

@plicease
Copy link
Contributor Author

I did not need to update Devel::AssertOS, not sure why.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants