support zapcore.BufferedWriteSyncer as an option.
#44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends our logging library to support buffered log writing by wrapping the underlying
WriteSyncerwithzapcore.BufferedWriteSyncer.Motivation
Previously, logs were written synchronously on every call, which can cause unnecessary I/O overhead under high log volume. With buffering enabled, log entries are accumulated in memory and only flushed to disk:
This reduces the frequency of disk writes and improves performance, while still guaranteeing that logs are eventually persisted.
Implementation
InitLogger()to introduceBufferedWriteSyncer.Close()method for now, because:zap.Loggeritself does not exposeClose(), onlySync().Sync()at shutdown is sufficient.Close()would require additional lifecycle handling (e.g. stopping background flush goroutines), which we may revisit if needed in the future.Testing