-
Notifications
You must be signed in to change notification settings - Fork 708
tiproxy: add note about reloading certificates once an hour (#22138) #22162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
tiproxy: add note about reloading certificates once an hour (#22138) #22162
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@dveeden This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the TiDB documentation to provide crucial information about how TiProxy manages TLS certificates. It specifically highlights that TiProxy reloads certificates from disk on an hourly basis, which means any modifications to certificate files will have a delay of up to one hour before they become active. This clarification aims to improve user understanding of certificate management within TiProxy. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a note to the documentation regarding TiProxy's hourly certificate reloading. The change is reflected in two files. My review includes a critical comment to resolve merge conflict markers found in enable-tls-between-components.md. I've also provided a suggestion for tiproxy/tiproxy-configuration.md to make the new note more concise, in line with the repository's style guide which advises against unnecessary words.
| <<<<<<< HEAD | ||
| ======= | ||
|
|
||
| - TiProxy reloads certificates from disk once an hour. | ||
| >>>>>>> 9cff933fa3 (tiproxy: add note about reloading certificates once an hour (#22138)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains merge conflict markers (<<<<<<<, =======, >>>>>>>). Please resolve these conflicts to ensure the document renders correctly.
| <<<<<<< HEAD | |
| ======= | |
| - TiProxy reloads certificates from disk once an hour. | |
| >>>>>>> 9cff933fa3 (tiproxy: add note about reloading certificates once an hour (#22138)) | |
| - TiProxy reloads certificates from disk once an hour. |
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #22138
First-time contributors' checklist
What is changed, added or deleted? (Required)
References:
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?