Router events (WIP Attempt 2) #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following events were added: 1. `handlestart` - emitted when the router starts to handle the router stack. 2. `layer` - emitted when a layer is macthed by the router. It returns the matched layer. 3. `handleend` - emitted when the router has completed handling the router stack. I am sure very sure about the name of the events, feedback are most welcome.
Closed
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
7e90c9e to
8643ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #49 for previous discussion.
I made a few other notable changes:
NOTE: if we decide to move forward with this PR then I can clean up the git history.