feat: add router cycle detection to prevent infinite loops #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects when a router is mounted on itself (directly or indirectly) and emits a warning to help developers identify cycles that cause requests to hang indefinitely.
When a router is mounted on itself through a chain of routers, requests that traverse the cycle hang indefinitely and eventually cause a stack overflow. This is difficult to debug because the application appears to work fine until a request hits the cyclic path.
This implements cycle detection in Router.prototype.use that:
Manual Test
Fixes expressjs/express#6809