Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR tightens the validation on subpaths and package types.
Subpaths are sanitized when calling
with_subpathto match the formatting rules: https://github.com/package-url/purl-spec/blob/7f7e82f73c38a4a339f88abf1f2aa031e9c7af23/PURL-SPECIFICATION.rst?plain=1#L313-L323Subpaths with
%2Esegments are handled the same as.segments: https://github.com/package-url/purl-spec/blob/7f7e82f73c38a4a339f88abf1f2aa031e9c7af23/PURL-SPECIFICATION.rst?plain=1#L339-L347 (changed by package-url/purl-spec#394)When using the string shapes instead of
PackageType, the package type validation is changed to require that the type begins with a letter: https://github.com/package-url/purl-spec/blob/7f7e82f73c38a4a339f88abf1f2aa031e9c7af23/PURL-SPECIFICATION.rst?plain=1#L136Checklist
Issue
What issue(s) does this PR close. Use the
closes #<issueNum>here.