Skip to content

Conversation

@matt-phylum
Copy link
Collaborator

@matt-phylum matt-phylum commented Apr 26, 2024

Overview

I noticed we had made changes but not made a release in a while.

Changelog:

  • Plus signs are escaped to improve compatibility with PURL implementations that incorrectly decode plus signs as spaces. (as proposed in define handling of plus and space package-url/purl-spec#261) (Pluses and spaces #14)
  • Percent signs are escaped if they are contained within any component of the PURL (eg name 100%23 becomes pkg:generic/100%2523 instead of pkg:generic/100%23 which would parse as name 100#) (encode percent signs #16)
  • PURLs are parsed primarily from the right, better matching the behavior described in the PURL spec and fixing some edge cases (eg pkg:generic/name@a%23/b%3F/c%40 gets name name and version a#/b?/c@ instead of namespace name@a#/b? and name c@) (better align parsing with spec #17)

Checklist

  • Does this PR have an associated issue?
  • Have you ensured that you have met the expected acceptance criteria?
  • Have you created sufficient tests?

Issue

What issue(s) does this PR close. Use the closes #<issueNum> here.

@matt-phylum matt-phylum requested review from a team as code owners April 26, 2024 17:54
Copy link

@Allan-Clements Allan-Clements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matt-phylum matt-phylum merged commit 3a22791 into main Apr 26, 2024
@matt-phylum matt-phylum deleted the matt/release branch April 26, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants