Skip to content

Fix Serializer return type for arrays of primitives #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yoeunes wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from
Open

Fix Serializer return type for arrays of primitives #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Type/Symfony/SerializerDynamicReturnTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@
use PHPStan\Analyser\Scope;
use PHPStan\Reflection\MethodReflection;
use PHPStan\Type\ArrayType;
use PHPStan\Type\BooleanType;
use PHPStan\Type\DynamicMethodReturnTypeExtension;
use PHPStan\Type\FloatType;
use PHPStan\Type\IntegerType;
use PHPStan\Type\MixedType;
use PHPStan\Type\ObjectType;
use PHPStan\Type\StringType;
use PHPStan\Type\Type;
use PHPStan\Type\TypeCombinator;
use function count;
Expand Down Expand Up @@ -67,6 +71,17 @@ private function getType(string $objectName): Type
return new ArrayType(new MixedType(false), $this->getType(substr($objectName, 0, -2)));
}

switch ($objectName) {
case 'int':
return new IntegerType();
case 'string':
return new StringType();
case 'bool':
return new BooleanType();
case 'float':
return new FloatType();
}

return new ObjectType($objectName);
}

Expand Down
1 change: 1 addition & 0 deletions tests/Type/Symfony/ExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ public function dataFileAsserts(): iterable
}

yield from $this->gatherAssertTypes(__DIR__ . '/data/serializer.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/serializer_primitives.php');

if (class_exists('Symfony\Component\HttpFoundation\InputBag')) {
yield from $this->gatherAssertTypes(__DIR__ . '/data/input_bag_from_request.php');
Expand Down
12 changes: 12 additions & 0 deletions tests/Type/Symfony/data/serializer_primitives.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php declare(strict_types = 1);

use function PHPStan\Testing\assertType;

$serializer = new \Symfony\Component\Serializer\Serializer();

assertType('int', $serializer->deserialize('...', 'int[]', 'json')[0] + 1);
assertType('string', $serializer->deserialize('...', 'string[]', 'json')[0] . '');
assertType('bool', !$serializer->deserialize('...', 'bool[]', 'json')[0]);
assertType('float', $serializer->deserialize('...', 'float[]', 'json')[0] + 1.0);
assertType('int', $serializer->deserialize('...', 'int[][]', 'json')[0][0] + 1);