Resolve template with value of BackEnum

[VincentLanglet]

Closes phpstan/phpstan#12219
Closes phpstan/phpstan#13638
Closes phpstan/phpstan#13282
Closes phpstan/phpstan#13782

[phpstan-bot]

This pull request has been marked as ready for review.

[staabm]

interessting.. does it also solve phpstan/phpstan#13782 ?

[VincentLanglet]

interessting.. does it also solve phpstan/phpstan#13782 ?

You don't appear on the issue bot https://github.com/phpstan/phpstan-src/actions/runs/19269104831?pr=4548
But I can take a look after this one is merged

[staabm]

You don't appear on the issue bot

yes, thats because the issue does not yet have a label like "bug" or "feature request".
issue-bot does not look into unlabelled issues

[staabm]

should this be the other way arround?

Suggested change

	&& $this->type->getBound()->equals(new ObjectType('BackedEnum'))
	&& new ObjectType('BackedEnum')->isSuperTypeOf($this->type->getBound())->yes()?

[staabm]

just had a look into the code-base. it seems we have spots where a Bound is compared using equals and sometimes it uses isSuperTypeOf.

I am not sure whether thats on purpose or an oversight

[VincentLanglet]

isSuperTypeOf is better here indeed, in case someone use

interface SuperBackedEnum extends \BackedEnum

and a template of SuperBackedEnum.

test added

[VincentLanglet]

You don't appear on the issue bot

yes, thats because the issue does not yet have a label like "bug" or "feature request". issue-bot does not look into unlabelled issues

Oh ok. Test added and seems like it does close phpstan/phpstan#13782.

[VincentLanglet]

Hi @staabm, when I run

vendor/bin/phpunit tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php --filter=testBug12219

both mutator are caught locally.

Any idea why it could be reported on CI ? Is there some cache ?

[VincentLanglet]

Hi @staabm, when I run

vendor/bin/phpunit tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php --filter=testBug12219

both mutator are caught locally.

Any idea why it could be reported on CI ? Is there some cache ?

As shown by 6cb52a2

if I tried the mutant reported by https://github.com/phpstan/phpstan-src/actions/runs/19963970402/job/57251263461?pr=4548

it failed.

I got the same issue with the following PR #4548

Either I misunderstand something, either it's buggy

[staabm]

I had a look but cannot yet make sense of it