Use dbal's native driverOptions

Author: janedbal

tests/Platform/Entity/PlatformEntity.php

@@ -98,7 +98,7 @@ class PlatformEntity
 	public $col_mixed;
 
 	/**
-	 * @ORM\Column(type="datetimetz", name="col_datetime", nullable=false)
+	 * @ORM\Column(type="datetime", name="col_datetime", nullable=false)
 	 * @var DateTimeInterface
 	 */
 	public $col_datetime;

tests/Platform/QueryResultTypeWalkerFetchTypeMatrixTest.php

@@ -19,7 +19,6 @@
 use Doctrine\ORM\Query;
 use Doctrine\ORM\Tools\SchemaTool;
 use LogicException;
-use mysqli;
 use PDO;
 use PHPStan\Php\PhpVersion;
 use PHPStan\Platform\Entity\PlatformEntity;
@@ -48,17 +47,10 @@
 use PHPUnit\Framework\Constraint\IsEqual;
 use PHPUnit\Framework\Constraint\IsIdentical;
 use Platform\TypedExpressionBooleanPiFunction;
-use SQLite3;
 use Throwable;
 use function floor;
-use function function_exists;
-use function get_debug_type;
 use function getenv;
-use function gettype;
 use function in_array;
-use function is_a;
-use function is_resource;
-use function method_exists;
 use function reset;
 use function sprintf;
 use function var_export;
@@ -3462,14 +3454,10 @@ public static function provideCases(): iterable
 			},
 		];
 
-		// TODO postgres ->setUseBooleanTrueFalseStrings()
 		// TODO string TypedExpression does not cast to string
-		// TODO sqlsrv uses native DateTime
 		// TODO would col_numeric_string differ from col_string results ?
 		// TODO dbal/orm versions
-		// TODO unknown driver to return mixed everywhere
 		// TODO double check all inferred unions
-		// TODO check else branches & default behaviour (other drivers)
 	}
 
 	/**
@@ -3488,10 +3476,14 @@ private function performDriverTest(
 		callable $assertStringified
 	): void
 	{
-		$connectionParams = ['driver' => $driver] + $this->getConnectionParamsForDriver($driver);
+		$connectionParams = [
+			'driver' => $driver,
+			'driverOptions' => self::CONNECTION_CONFIGS[$configName],
+		] + $this->getConnectionParamsForDriver($driver);
+
 		$dql = sprintf($dqlTemplate, PlatformEntity::class);
 
-		$connection = $this->createConnection($connectionParams, self::CONNECTION_CONFIGS[$configName]);
+		$connection = $this->createConnection($connectionParams);
 		$query = $this->getQuery($connection, $dql, $data);
 		$sql = $query->getSQL();
 
@@ -3538,11 +3530,9 @@ private function performDriverTest(
 
 	/**
 	 * @param array<string, mixed> $connectionParams
-	 * @param array<mixed> $connectionAttributes
 	 */
 	private function createConnection(
-		array $connectionParams,
-		array $connectionAttributes
+		array $connectionParams
 	): Connection
 	{
 		$connection = DriverManager::getConnection($connectionParams);
@@ -3554,9 +3544,6 @@ private function createConnection(
 			$connection->executeQuery('USE foo');
 		}
 
-		$nativeConnection = $this->getNativeConnection($connection);
-		$this->setupAttributes($nativeConnection, $connectionAttributes);
-
 		return $connection;
 	}
 
@@ -3976,70 +3963,6 @@ private static function stringifyType(Type $type): Type
 		});
 	}
 
-	/**
-	 * @param mixed $nativeConnection
-	 * @param array<mixed> $attributes
-	 */
-	private function setupAttributes($nativeConnection, array $attributes): void
-	{
-		if ($nativeConnection instanceof PDO) {
-			foreach ($attributes as $attribute => $value) {
-				$set = $nativeConnection->setAttribute($attribute, $value);
-				if (!$set) {
-					throw new LogicException(sprintf('Failed to set attribute %s to %s', $attribute, $value));
-				}
-			}
-
-		} elseif ($nativeConnection instanceof mysqli) {
-			foreach ($attributes as $attribute => $value) {
-				$set = $nativeConnection->options($attribute, $value);
-				if (!$set) {
-					throw new LogicException(sprintf('Failed to set attribute %s to %s', $attribute, $value));
-				}
-			}
-
-		} elseif (is_a($nativeConnection, 'PgSql\Connection', true)) {
-			if ($attributes !== []) {
-				throw new LogicException('Cannot set attributes for PgSql\Connection driver');
-			}
-
-		} elseif ($nativeConnection instanceof SQLite3) {
-			if ($attributes !== []) {
-				throw new LogicException('Cannot set attributes for ' . SQLite3::class . ' driver');
-			}
-
-		} elseif (is_resource($nativeConnection)) { // e.g. `resource (pgsql link)` on PHP < 8.1 with pgsql driver
-			if ($attributes !== []) {
-				throw new LogicException('Cannot set attributes for this resource');
-			}
-
-		} else {
-			throw new LogicException('Unexpected connection: ' . (function_exists('get_debug_type') ? get_debug_type($nativeConnection) : gettype($nativeConnection)));
-		}
-	}
-
-	/**
-	 * @return mixed
-	 */
-	private function getNativeConnection(Connection $connection)
-	{
-		if (method_exists($connection, 'getNativeConnection')) {
-			return $connection->getNativeConnection();
-		}
-
-		if (method_exists($connection, 'getWrappedConnection')) {
-			if ($connection->getWrappedConnection() instanceof PDO) {
-				return $connection->getWrappedConnection();
-			}
-
-			if (method_exists($connection->getWrappedConnection(), 'getWrappedResourceHandle')) {
-				return $connection->getWrappedConnection()->getWrappedResourceHandle();
-			}
-		}
-
-		throw new LogicException('Unable to get native connection');
-	}
-
 	private static function defaultStringification(Driver $driver, int $php, string $configName): bool
 	{
 		if ($configName === self::CONFIG_DEFAULT) {