Test datetime field

Author: janedbal

tests/Platform/Entity/PlatformEntity.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Platform\Entity;
 
+use DateTimeInterface;
 use Doctrine\ORM\Mapping as ORM;
 
 /**
@@ -96,4 +97,10 @@ class PlatformEntity
 	 */
 	public $col_mixed;
 
+	/**
+	 * @ORM\Column(type="datetimetz", name="col_datetime", nullable=false)
+	 * @var DateTimeInterface
+	 */
+	public $col_datetime;
+
 }

tests/Platform/QueryResultTypeWalkerFetchTypeMatrixTest.php

@@ -3,6 +3,7 @@
 namespace PHPStan\Platform;
 
 use Cache\Adapter\PHPArray\ArrayCachePool;
+use DateTimeImmutable;
 use Doctrine\Common\Annotations\AnnotationReader;
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Driver;
@@ -203,6 +204,24 @@ public static function provideCases(): iterable
 			},
 		];
 
+		yield ' 0.1' => [
+			'data' => self::dataDefault(),
+			'select' => 'SELECT 0.1 FROM %s t',
+			'mysql' => new ConstantStringType('0.1'),
+			'sqlite' => new ConstantFloatType(0.1),
+			'pdo_pgsql' => new ConstantStringType('0.1'),
+			'pgsql' => new ConstantStringType('0.1'),
+			'mssql' => new MixedType(),
+			'mysqlResult' => '0.1',
+			'sqliteResult' => 0.1,
+			'pdoPgsqlResult' => '0.1',
+			'pgsqlResult' => '0.1',
+			'mssqlResult' => '.1',
+			'shouldStringify' => static function (Driver $driver, int $php, string $configName): bool {
+				return self::defaultStringification($driver, $php, $configName);
+			},
+		];
+
 		yield ' 1e0' => [
 			'data' => self::dataDefault(),
 			'select' => 'SELECT 1e0 FROM %s t',
@@ -3425,6 +3444,27 @@ public static function provideCases(): iterable
 			},
 		];
 
+		yield 'COALESCE(t.col_datetime, t.col_datetime)' => [
+			'data' => self::dataDefault(),
+			'select' => 'SELECT COALESCE(t.col_datetime, t.col_datetime) FROM %s t',
+			'mysql' => self::string(),
+			'sqlite' => self::string(),
+			'pdo_pgsql' => self::string(),
+			'pgsql' => self::string(),
+			'mssql' => self::mixed(),
+			'mysqlResult' => '2024-01-31 12:59:59',
+			'sqliteResult' => '2024-01-31 12:59:59',
+			'pdoPgsqlResult' => '2024-01-31 12:59:59',
+			'pgsqlResult' => '2024-01-31 12:59:59',
+			'mssqlResult' => '2024-01-31 12:59:59.000000', // doctrine/dbal changes default ReturnDatesAsStrings to true
+			'shouldStringify' => static function (): bool {
+				return false;
+			},
+		];
+
+		// TODO postgres ->setUseBooleanTrueFalseStrings()
+		// TODO string TypedExpression does not cast to string
+		// TODO sqlsrv uses native DateTime
 		// TODO would col_numeric_string differ from col_string results ?
 		// TODO dbal/orm versions
 		// TODO unknown driver to return mixed everywhere
@@ -3777,6 +3817,11 @@ private static function numericString(): Type
 		]);
 	}
 
+	private static function string(): Type
+	{
+		return new StringType();
+	}
+
 	private static function numericStringOrNull(): Type
 	{
 		return TypeCombinator::addNull(new IntersectionType([
@@ -3854,6 +3899,7 @@ public static function dataDefault(): array
 				'col_string' => 'foobar',
 				'col_string_nullable' => null,
 				'col_mixed' => 1,
+				'col_datetime' => new DateTimeImmutable('2024-01-31 12:59:59'),
 			],
 		];
 	}
@@ -3879,6 +3925,7 @@ public static function dataAllIntLike(): array
 				'col_string' => '1',
 				'col_string_nullable' => null,
 				'col_mixed' => 1,
+				'col_datetime' => new DateTimeImmutable('2024-01-31 12:59:59'),
 			],
 		];
 	}
@@ -3905,6 +3952,7 @@ public static function dataSqrt(): array
 				'col_string' => 'foobar',
 				'col_string_nullable' => null,
 				'col_mixed' => 1,
+				'col_datetime' => new DateTimeImmutable('2024-01-31 12:59:59'),
 			],
 		];
 	}