Skip to content

Change array syntax to more commonly used #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kkmuffme wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Change array syntax to more commonly used #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Types/AbstractList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,16 @@ public function __toString(): string
return 'array<' . $this->keyType . ',' . $this->valueType . '>';
}

// the "(...)[]" syntax is less common
// and not visually distinctive from conditional types and callables
// additionally, it significantly differs from PHP native type hint
if ($this->valueType instanceof Compound) {
return '(' . $this->valueType . ')[]';
return 'array<' . $this->valueType . '>';
}

// 'foo bar'[] or array{a: int}[] is not readable
if (preg_match('/[^\w\\\\]/', (string) $this->valueType)) {
return 'array<' . $this->valueType . '>';
}

return $this->valueType . '[]';
Expand Down
Loading