#677 UI Updates #679
Open
#677 UI Updates #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated TODO comment to use JSX syntax.
Member
Author
|
To the Contact Table TODO: -- |
RNR1
reviewed
Dec 3, 2025
Contributor
RNR1
left a comment
RNR1
left a comment
There was a problem hiding this comment.
Looks good overall, just some cleanups before it's ready to go!
RNR1
approved these changes
Dec 14, 2025
| title="Civic" | ||
| description="Publicity and Community Engagement" | ||
| /> | ||
| {ROLE_CARDS.map(card => ( |
Contributor
There was a problem hiding this comment.
While this approach reduces repetition in the JSX, it makes the component's flow less intuitive, as you have to scroll up to see which circles we render. It also results in more lines of code. I'm not too concerned about mapping these circle components and would rather use this approach for dynamic data, where we don't know what data we receive, rather than for static data that doesn't change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Change Summary
Updated Text Font inconsistency in About and Join the Team pages
Added some Review: and Fixme: s and TODO: for possible review and updates
Change Reason
Just UI updates, after this latest or most updated contributors can be fetched and updated.
Related Issue: #677