Use clearAllTags() iinstead of dispatch(resetFilterFunction()) #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for implementing this @astoppop ! Since this addresses a version 2.1 concern, I'm deferring my review of this one until I get through the backlog of version 2.0 tickets. I'll come back to this one once 2.0 is live 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Change Summary
Switching between resources now also visually resets the filter.
Change Reason
If a user has a filter / filters selected on resource type A (ex- Water), switches to resource type B (ex- Food) and then goes back to resource type A, all the filters are visually toggled "on" but the filters are not filtering the list. A user has to toggle them off and on again to get them to apply.
Related Issue: #541