Fix/tray toggle recording #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tray icon became unresponsive after a recording cycle because thread references were not cleaned up and race conditions existed between the monitoring and recording threads. - Add `_recording_started` flag to synchronize icon updates - Clean up thread references in `callback_stop_recording` - Pass `icon` to `start_recording` to track startup state - Fix minor linting issue and set default action for Stop menu item Generated with opencode Co-Authored-By: opencode <noreply@netresearch.com>
Add 'is not None' checks before calling 'is_alive()' on thread attributes. This prevents an AttributeError when a recording has been stopped and the thread reference has been cleared. Generated with opencode Co-Authored-By: opencode <noreply@netresearch.com>
When stopping a recording session, the tray icon stayed in the recording or busy state until all threads were joined. By explicitly setting the recording and busy flags and calling update_icon before joining, the icon returns to its initial state immediately upon user action. This also allows the monitoring thread loop to exit cleanly as soon as the stop command is issued. Generated with opencode Co-Authored-By: opencode <noreply@netresearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1.
Remaining work: