Fix/upload credits #37
Merged
+8,257
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bhavyagor12
commented
Dec 11, 2025
bhavyagor12
commented
- wallets with insufficient balance get errors throw on failed upload
- check upload costs before upload folder
mid changes with checking upload credits
1. focus on throwing error on insufficient funds 2. added mocks for wallets without balance 3. throw error on missing txOrManifestId
|
🚀 Snapshot release published: Install with: pnpm add permaweb-deploy@0.0.0-alpha-20251211100922 |
dtfiedler
approved these changes
Dec 11, 2025
dtfiedler
requested changes
Dec 11, 2025
Collaborator
dtfiedler
left a comment
dtfiedler
left a comment
There was a problem hiding this comment.
@bhavyagor12 - please run prettier
Member
Author
|
@dtfiedler thanks for the review!! I ran - Let me know if I m doing something wrong, thanks - Screen.Recording.2025-12-12.at.12.52.08.PM.mov |
|
🚀 Snapshot release published: Install with: pnpm add permaweb-deploy@0.0.0-alpha-20251218112416 |
|
🚀 Snapshot release published: Install with: pnpm add permaweb-deploy@0.0.0-alpha-20251218112422 |
|
🚀 Snapshot release published: Install with: pnpm add permaweb-deploy@0.0.0-alpha-20251218112729 |
NickJ202
approved these changes
Jan 7, 2026
|
🚀 Snapshot release published: Install with: pnpm add permaweb-deploy@0.0.0-alpha-20260107222737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.