fix(docker): use rustup for faster and reliable builds #592
+769
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced manual compilation of Rust from source with `rustup` installer - Added `curl` and `ca-certificates` to system dependencies - Fixes `python: not found` build error - Significantly reduces Docker build time
…station Implements device-controlled registration and attestation system with: - Device registration with public key, wallet, and signed hash - Registration status checking with multiple_wallet enforcement - Attestation challenge generation with unique nonces - Response verification with nonce replay protection - Automatic per-user nonce process management Registration process is hidden and only accessible through the device, ensuring proper validation and authorization for all operations.
|
related: #132 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current Dockerfile attempts to build Rust from source. This fails because python is missing from the base image, and specifically causes an exec: python: not found error during ./configure. Additionally, building Rust from source is extremely resource-intensive and slow for a deployment container.
Solution
Switched to using rustup (sh.rustup.rs) to install the stable Rust toolchain.
Added curl and ca-certificates to the apt-get install list, as they are required for the installation script.
Result
Fixes Build: The Docker image now builds successfully.
Performance: Build time is reduced from potentially hours to a few minutes.
Reliability: Uses official pre-compiled binaries instead of local compilation.