Skip to content

fix: Do not crash on unsuported signature types #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
speeddragon wants to merge 3 commits into from
Closed

fix: Do not crash on unsuported signature types #571

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55fe450
fix: Do not crash on unsuported signature types
speeddragon Nov 26, 2025
d19b3c6
test: Add test
speeddragon Nov 26, 2025
e02cdd1
fix: Test
speeddragon Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/dev_arweave_common.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,13 @@ generate_id(TX, unsigned) ->
generate_signature_data_segment(TX#tx{ owner = ?DEFAULT_OWNER })).

generate_signature_data_segment(TX = #tx{ format = ans104 }) ->
ar_bundles:data_item_signature_data(TX);
try ar_bundles:data_item_signature_data(TX) catch
Class:Error:Stack ->
?event(error, {invalid_tx, {class, Class},
{error, Error},
{stack, Stack}}),
<<>>
end;
generate_signature_data_segment(TX) ->
ar_tx:generate_signature_data_segment(TX).

Expand Down Expand Up @@ -193,4 +199,16 @@ normalize_data_root(Item = #tx{data = Bin, format = 2})
Item#tx{data_root = ar_tx:data_root(Bin)};
normalize_data_root(Item) -> Item.


%% Tests

do_not_crash_with_unsupported_signature_type_test() ->
SignatureType = unsupported_tx_signature_type,
TX = #tx{
format = ans104,
signature = <<0:256>>,
signature_type = SignatureType,
owner = <<0:256>>,
data_size = 3,
data = <<0, 1, 2>>
},
?assert(is_record(reset_ids(TX), tx)).