Skip to content

Fix/allow process cache scoping #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samcamwilliams merged 2 commits into from
Oct 17, 2025
Merged

Fix/allow process cache scoping #522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31424a5
feat: allow process cache lookups to be scoped via node message
samcamwilliams Oct 11, 2025
f7c45d3
fix: normalize store correctly in `dev_process_cache`
samcamwilliams Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/dev_process_cache.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,17 @@ path(ProcID, Ref, PathSuffix, Opts) ->
latest(ProcID, Opts) -> latest(ProcID, [], Opts).
latest(ProcID, RequiredPath, Opts) ->
latest(ProcID, RequiredPath, undefined, Opts).
latest(ProcID, RawRequiredPath, Limit, Opts) ->
?event(
{latest_called,
{proc_id, ProcID},
{required_path, RawRequiredPath},
{limit, Limit}
}
),
latest(ProcID, RawRequiredPath, Limit, RawOpts) ->
Scope = hb_opts:get(process_cache_scope, local, RawOpts),
% Normalize the store descriptor to a list of stores.
UnscopedStore =
case hb_opts:get(store, no_viable_store, RawOpts) of
StoreMsg when is_map(StoreMsg) -> [StoreMsg];
Other -> Other
end,
% Apply the scope to the store and update the options message.
ScopedStore = hb_store:scope(UnscopedStore, Scope),
Opts = RawOpts#{ store => ScopedStore },
% Convert the required path to a list of _binary_ keys.
RequiredPath =
case RawRequiredPath of
Expand Down
Loading