K8SPSMDB-1451: Wait until primary elected after rs initialization #2149
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egegunes
requested review from
gkech,
nmarukovich and
pooknull
as code owners
pooknull
reviewed
Dec 16, 2025
|
|
||
| out := strings.Trim(stdout.String(), "\n") | ||
| if out != "true" { | ||
| return errors.New("is not the writable primary") |
Contributor
There was a problem hiding this comment.
Suggested change
| return errors.New("is not the writable primary") | |
| return errors.New(pod.Name+" is not the writable primary") |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the replica set initialization process by replacing a blind 5-second wait after rs.initiate with an intelligent backoff retry mechanism that polls for primary election. The change makes the initialization process more reliable by actively checking when the primary is elected rather than assuming 5 seconds is always sufficient.
- Replaces fixed 5-second sleep with a backoff retry mechanism that actively checks for primary election
- Uses MongoDB's
hellocommand to verify the node is a writable primary - Adds exponential backoff with 5 retry steps and configurable timing parameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mayankshah1607
previously approved these changes
Dec 18, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
commit: 65db8e0 |
mayankshah1607
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Operator blindly waits for 5 seconds after running
rs.initiate.Solution:
Check if primary is elected with backoff retry.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability