Skip to content

Conversation

@gkech
Copy link
Contributor

@gkech gkech commented Dec 11, 2025

K8SPSMDB-1413 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:

Check also: K8SPSMDB-1413-e2e-test

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Dec 11, 2025
@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/M 30-99 lines labels Dec 11, 2025
@egegunes egegunes added this to the v1.22.0 milestone Dec 15, 2025
@gkech gkech marked this pull request as ready for review December 17, 2025 11:47
Copy link
Contributor

@egegunes egegunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkech please add description to the PR

@hors hors requested a review from mayankshah1607 December 18, 2025 10:34
Comment on lines +316 to +320
// cert-manager sets the Certificate as the controller owner.
// In that case, the operator should not set a new controller reference.
if metav1.GetControllerOf(secret) != nil {
continue
}
Copy link
Member

@mayankshah1607 mayankshah1607 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just check if the error below (when calling SetControllerReference) returns a controllerutil.AlreadyOwnedError{} type using errors.Is

@JNKPercona
Copy link
Collaborator

Test Name Result Time
arbiter passed 00:11:38
balancer passed 00:18:37
cross-site-sharded passed 00:19:04
custom-replset-name passed 00:10:37
custom-tls passed 00:14:58
custom-users-roles passed 00:11:06
custom-users-roles-sharded passed 00:12:01
data-at-rest-encryption passed 00:12:54
data-sharded passed 00:22:57
demand-backup passed 00:16:21
demand-backup-eks-credentials-irsa passed 00:00:08
demand-backup-fs passed 00:22:55
demand-backup-if-unhealthy passed 00:08:57
demand-backup-incremental passed 00:46:43
demand-backup-incremental-sharded passed 01:00:17
demand-backup-physical-parallel passed 00:08:28
demand-backup-physical-aws passed 00:12:33
demand-backup-physical-azure passed 00:11:45
demand-backup-physical-gcp-s3 passed 00:11:19
demand-backup-physical-gcp-native passed 00:12:15
demand-backup-physical-minio passed 00:21:04
demand-backup-physical-minio-native passed 00:20:32
demand-backup-physical-sharded-parallel passed 00:10:55
demand-backup-physical-sharded-aws passed 00:18:08
demand-backup-physical-sharded-azure passed 00:17:48
demand-backup-physical-sharded-gcp-native passed 00:17:40
demand-backup-physical-sharded-minio passed 00:17:02
demand-backup-physical-sharded-minio-native passed 00:17:28
demand-backup-sharded passed 00:25:31
expose-sharded passed 00:34:11
finalizer passed 00:09:57
ignore-labels-annotations passed 00:07:41
init-deploy passed 00:13:17
ldap passed 00:09:04
ldap-tls passed 00:12:40
limits passed 00:06:24
liveness passed 00:08:20
mongod-major-upgrade passed 00:12:01
mongod-major-upgrade-sharded passed 00:21:11
monitoring-2-0 passed 00:25:00
monitoring-pmm3 passed 00:27:47
multi-cluster-service passed 00:15:20
multi-storage passed 00:19:11
non-voting-and-hidden passed 00:16:56
one-pod passed 00:08:36
operator-self-healing-chaos passed 00:13:03
pitr passed 00:32:19
pitr-physical passed 01:00:52
pitr-sharded passed 00:22:00
pitr-to-new-cluster passed 00:25:23
pitr-physical-backup-source passed 00:54:22
preinit-updates passed 00:05:16
pvc-resize passed 00:13:15
recover-no-primary passed 00:26:38
replset-overrides passed 00:16:39
replset-remapping passed 00:08:41
replset-remapping-sharded passed 00:17:01
rs-shard-migration passed 00:13:45
scaling passed 00:11:30
scheduled-backup passed 00:17:59
security-context passed 00:07:23
self-healing-chaos passed 00:15:22
service-per-pod passed 00:19:21
serviceless-external-nodes passed 00:07:43
smart-update passed 00:08:24
split-horizon passed 00:08:14
stable-resource-version passed 00:04:57
storage passed 00:07:51
tls-issue-cert-manager passed 00:29:40
upgrade passed 00:10:01
upgrade-consistency passed 00:06:34
upgrade-consistency-sharded-tls passed 00:53:40
upgrade-sharded passed 00:20:27
upgrade-partial-backup passed 00:15:29
users passed 00:17:37
version-service passed 00:25:32
Summary Value
Tests Run 76/76
Job Duration 03:20:09
Total Test Time 22:36:53

commit: 8a1bc0e
image: perconalab/percona-server-mongodb-operator:PR-2135-8a1bc0ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants