-
Notifications
You must be signed in to change notification settings - Fork 161
K8SPSMDB-1413 skip setting controller owner on secrets owned by Certificates created by cert-manager #2135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ficates created by cert-manager
egegunes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkech please add description to the PR
| // cert-manager sets the Certificate as the controller owner. | ||
| // In that case, the operator should not set a new controller reference. | ||
| if metav1.GetControllerOf(secret) != nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just check if the error below (when calling SetControllerReference) returns a controllerutil.AlreadyOwnedError{} type using errors.Is
commit: 8a1bc0e |
CHANGE DESCRIPTION
Problem:
Check also:
K8SPSMDB-1413-e2e-testCause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability