Skip to content

Bugfix/table drag and drop #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkCuypersPpw merged 2 commits into from
Dec 4, 2025
Merged

Bugfix/table drag and drop #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3017251
Lock table record row dragging visually within tbody element
glenstaes Nov 22, 2025
aa84dcc
Fix table row drag not happening on first clicks
glenstaes Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/ppwcode/ng-common-components/src/lib/table/abstract-table.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export abstract class AbstractTableComponent<TRecord, TData = FormArray<FormGrou
public dataSource: WritableSignal<MatTableDataSource<TableRecord<TRecord>>> = linkedSignal(() => {
return new MatTableDataSource(this.localRecords())
})
dragDisabled = true

public selection = new SelectionModel<TableRecord<TRecord>>(
true,
[],
Expand Down
19 changes: 5 additions & 14 deletions projects/ppwcode/ng-common-components/src/lib/table/table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,7 @@
<ng-container matColumnDef="rowDrag">
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let element" class="drag-table-cell">
<mat-icon
cdkDragHandle
mat-ripple
class="drag-handle"
(touchstart)="dragDisabled = false"
(touchend)="dragDisabled = true"
(mousedown)="dragDisabled = false"
(mouseup)="dragDisabled = true"
>drag_indicator
</mat-icon>
<mat-icon cdkDragHandle mat-ripple class="drag-handle">drag_indicator </mat-icon>
</td>
@if (footerData() !== undefined) {
<td mat-footer-cell *matFooterCellDef></td>
Expand Down Expand Up @@ -165,13 +156,13 @@
<tr mat-header-row *matHeaderRowDef="columnNames(); sticky: !!options()?.header?.sticky"></tr>
<tr
mat-row
[class.ppw-table-row-enter]="!disableAnimations()"
*matRowDef="let row; columns: columnNames()"
cdkDrag
[cdkDragDisabled]="dragDisabled"
(cdkDragReleased)="dragDisabled = true"
*matRowDef="let row; columns: columnNames()"
[class.ppw-table-row-enter]="!disableAnimations()"
[class.highlight]="options()?.rows?.highlightOnHover"
[class.clickable]="options()?.rows?.onClick || options()?.rows?.onCtrlClick || expandable()"
[cdkDragLockAxis]="'y'"
[cdkDragBoundary]="'tbody'"
></tr>
@if (expandable()) {
<tr mat-row *matRowDef="let row; columns: ['expandedDetail']" class="ppw-table-expanded-row"></tr>
Expand Down
2 changes: 1 addition & 1 deletion projects/ppwcode/ng-common-components/src/lib/table/table.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
}
}

.ppw-table-row-enter {
.ppw-table-row-enter:not(.cdk-drag-preview) {
animation: slide-in-row 0.25s ease-in-out;
}

Expand Down