Make libass glyph and cache sizes configurable #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have introduced an AssHandlerConfig with defaults for the glyph and cache that preserve the existing behavior but allows applications to configure the cache limits based on their needs.
I was able to test a glyph size of 10000 and a cache size of 128 MB for a few months playing media heavily on a Shield TV and found the experience to be much smoother. I only crashed one time.
Usage is as simple as setting the config when you new up the AssHandler.
private val assHandler by lazy { AssHandler(AssRenderType.OVERLAY_CANVAS, config = AssHandlerConfig(glyphSize = 10000, cacheSize = 128)) }The config and all members within the config are optional so a consumer can mix and match their own settings based on their needs.