-
Notifications
You must be signed in to change notification settings - Fork 61
Adding Dockerfile and Docker Compose deployment #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey!
That's the really important part here I will be having a look at! Regarding the file structure, as I mentioned, I am not really versed with Docker and probably the Dockerfile should remain in the repository root, but I believe everything else shouldn't, including the entry point. Since it's just a shell script and the paths seem fixed to
That would mean I'd have to maintain it under updates, and my activity on this project has already become pretty sparse due to limited time, so it may actually be better if somebody who actively uses Docker also maintains a Docker image. I will happily link to your image in the readme. |
|
Thanks a lot for the positive reply, Patrick! And yes, having the Dockerfile in the root is the standard everyone uses. I don't think it's a good idea to change that. But if you like I could put the entrypoint.sh and example Docker Compose deployment in a separate docker directory. It would make clear that the entrypoint.sh is not needed for a deployment on the host. Personally I'm fine with maintaining the Docker image. I could watch this Repo and make sure that when things change, the Docker deployment still works. And you could always reach out to me when there are any Docker related issues. |
|
@pdinklag, what do you say, can this be merged? |
|
Did you get to try the Docker installation yet? I have added support for custom stats using Docker. So now the Docker install should allow everything the normal installation can do. |
Hello smart people,
I created a Docker image for this project.
Additionally I added a full example deployment using Docker Compose so people can jump right into testing MinecraftStats.
Since I really like working with Docker environments and wanted to use the MinecraftStats project with my Minecraft server running inside Docker I added support for it.
I also wrote Documentation and a troubleshooting step for a problem I was stuck at for a while.
For the time being I published the image under my name as chrisbesch/minecraft_stats.
I'd like you, @pdinklag, to build the image yourself and publish it under your name instead since it's still your and not my project.
I'm looking forward to your comments!