Bump node to v22 #38
Merged
Bump node to v22 #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Docker image documentation to reflect the new supported Node.js version.
- Update Node.js version from v18 to v22 in the README.md file.
Files not reviewed (2)
- Dockerfile: Language not supported
- package.json: Language not supported
ain
requested changes
May 8, 2025
Member
ain
left a comment
ain
left a comment
There was a problem hiding this comment.
Thanks for the bump! Some points made for considerations.
| apt-get install -y google-cloud-sdk nodejs yarn google-chrome-unstable --no-install-recommends && \ | ||
| apt-get autoremove && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
| apt-get autoclean && \ |
package.json
Outdated
Comment on lines
11
to
14
| "build": "docker build -t gcp-ruby/test -f ./Dockerfile .", | ||
| "run": "docker run --rm -it --entrypoint sh gcp-ruby/test:latest", | ||
| "clean": "docker image rm gcp-ruby/test:latest", | ||
| "full-test": "npm run test && npm run build && npm run run && npm run clean" |
Member
There was a problem hiding this comment.
I'd avoid adding this over NPM, since it adds unnecessary complexity and failure layer as well as confusion (test vs full-test).
GitHub Actions is already testing against this and instead of local tests you could simply push the PR up and get it tested by Actions for you.
dockerlint was only added here because it's a Node module that does the linting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.