explicitly resetting io stream to start after pandas read. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjohns
reviewed
Dec 7, 2020
Contributor
There was a problem hiding this comment.
Nice catch!
Would it make sense to maintain this invariant "higher up in the code"? E.g. possibly here
Line 139 in 241df8e
node._stream.seek(0)
or
node.stream.seek(0) # where I think the seek method is added to the StreamManager
. I wonder if test_node_stream_property_returns_at_byte_0_after_parse will fail for xlsx too? If so that would be another argument for the "higher up in the code" solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing broken assertion in list item 2 in issue #52 . This wont fix item 1 in #52, but it's a step closer to non-broken tests.
I ran
noxand there are 2 broken tests instead of 3 after this update.