Changed str_to_u32 to remove unsafe code. Need to verify Native Endia… #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n works on all platforms
Owner
|
Yes, it's strange how something is crashing in release builds. Thanks for finding this pattern to get rid of this transmute. I think I do things wrong with endianess between intel and arm and rgb and bgr pixel formats. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi just a minor detail, I saw some unsafe code that might have impacted an issue that I found,
it doesnt fix the problem but you might be interested in incorporating it, assuming its ok.
Also changed the tests to be optimized as the issue I have only is present in release builds.
All tests pass ...