Skip to content

refactor: cache filtered sessions and speakers between recompositions #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbeyls merged 1 commit into from
Mar 21, 2025
Merged

refactor: cache filtered sessions and speakers between recompositions #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions shared/ui/src/commonMain/kotlin/com/androidmakers/ui/agenda/AgendaPager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import androidx.compose.material3.Text
import androidx.compose.material3.pulltorefresh.PullToRefreshBox
import androidx.compose.material3.pulltorefresh.rememberPullToRefreshState
import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.ui.Modifier
import com.androidmakers.ui.common.EmptyLayout
Expand Down Expand Up @@ -68,18 +69,23 @@ fun AgendaPager(
state = pagerState,
) { page ->
val pullRefreshState = rememberPullToRefreshState()
val day = days[page]
val sessionsPerStartTime = remember(day, sessionFilters) {
day.sessions
.filter(sessionFilters)
.groupBy { it.startDate.formatShortTime() }
}

PullToRefreshBox(
isRefreshing = isRefreshing,
onRefresh = onRefresh,
state = pullRefreshState
) {
val sessions = days[page].sessions.filter(sessionFilters)
if (sessions.isEmpty()) {
if (sessionsPerStartTime.isEmpty()) {
EmptyLayout()
} else {
AgendaColumn(
sessionsPerStartTime = sessions.groupBy { it.startDate.formatShortTime() },
sessionsPerStartTime = sessionsPerStartTime,
onSessionClick = onSessionClick,
onApplyForAppClinicClick = onApplyForAppClinicClick,
onSessionBookmark = onSessionBookmark
Expand Down
7 changes: 4 additions & 3 deletions shared/ui/src/commonMain/kotlin/com/androidmakers/ui/speakers/SpeakerListScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,13 @@ fun SpeakerScreen(
}

is Lce.Content -> {

var text by rememberSaveable { mutableStateOf("") }
var expanded by rememberSaveable { mutableStateOf(false) }
val content = (state as Lce.Content<SpeakersUiState>).content

val filteredSpeakers = content.speakers.filter { it.name?.contains(text, ignoreCase = true) == true }
val speakers = (state as Lce.Content<SpeakersUiState>).content.speakers
val filteredSpeakers = remember(speakers, text) {
speakers.filter { it.name?.contains(text, ignoreCase = true) == true }
}

var searchHeight by remember { mutableStateOf(56.dp) }

Expand Down