Skip to content

Added support for dropdown button menu align right #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feldsam wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added support for dropdown button menu align right #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59ace3a
Added support for dropdown button menu align right
feldsam Jun 16, 2018
730d0f9
Fixed coding strandards
feldsam Aug 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/Bootstrapper/DropdownButton.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ class DropdownButton extends RenderedObject
* @var bool Whether the button should drop up
*/
protected $dropup = false;

/**
* @var bool Whether the menu should align right
*/
protected $alignRight = false;

/**
* Set the label of the button
Expand Down Expand Up @@ -167,6 +172,18 @@ public function dropup()

return $this;
}

/**
* Sets the dropdown menu align right
*
* @return $this
*/
public function alignRight()
{
$this->alignRight = true;

return $this;
}

/**
* Creates a normal dropdown button
Expand Down Expand Up @@ -323,7 +340,13 @@ public function render()
$string .= "<button {$attributes}>{$this->label} <span class='caret'></span></button>";
}

$string .= "<ul class='dropdown-menu' role='menu' aria-labelledby='dLabel'>";
$string .= "<ul class='dropdown-menu";

if ($this->alignRight) {
$string .= " dropdown-menu-right";
}

$string .= "' role='menu' aria-labelledby='dLabel'>";
$string .= $this->renderItems();
$string .= "</ul>";
$string .= "</div>";
Expand Down
7 changes: 7 additions & 0 deletions tests/spec/Bootstrapper/DropdownButtonSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,13 @@ function it_can_be_made_to_dropup()
);
}

function it_can_be_made_to_alignRight()
{
$this->alignRight()->render()->shouldBe(
"<div class='btn-group'><button class='btn btn-default dropdown-toggle' data-toggle='dropdown' type='button'> <span class='caret'></span></button><ul class='dropdown-menu dropdown-menu-right' role='menu' aria-labelledby='dLabel'></ul></div>"
);
}

function it_has_shortcut_methods()
{
$types = ['primary', 'danger', 'warning', 'success', 'info', 'normal'];
Expand Down