Skip to content

Fix productMap definition #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
B77Mills merged 3 commits into from
Oct 21, 2025
Merged

Fix productMap definition #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80ef15b
correct map def when productId present
B77Mills Oct 20, 2025
d7323f2
Ensure Products key is & default value
B77Mills Oct 20, 2025
d36b2e6
Make productId optional
B77Mills Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/graphql/src/definitions/customer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ input CustomerExternalIdsInput {

input RapidCustomerIdentificationMutationInput {
"The product ID to associate with this rapid identification."
productId: Int!
productId: Int
"The customer's email address."
email: String!
"First name of customer, up to 100 characters long"
Expand Down
2 changes: 1 addition & 1 deletion services/graphql/src/resolvers/customer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ module.exports = {

const promoCode = input.promoCode ? input.promoCode.trim() : null;
if (promoCode && promoCode.length > 50) throw new UserInputError('The promo code must be 50 characters or fewer.');
const productMap = new Map([[input.productId, true]]);
const productMap = new Map([...(input.productId ? [[input.productId, true]] : [])]);

const deploymentTypeIdMap = input.deploymentTypeIds.reduce((map, id) => {
map.set(id, true);
Expand Down